Add 2 more Expr simplifications related to negative numbers, enable NOT concretization #1017
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
more-expr-simp
branch
from
5e9c8a2 to
1044b7f
Compare
Co-authored-by: blishko <blishko@argot.org>
Co-authored-by: blishko <blishko@argot.org>
blishko
reviewed
Feb 10, 2026
src/EVM/Expr.hs
Outdated
|
|
||
| -- Negation: ~x + 1 = 0 - x (two's complement) | ||
| go (Add (Lit 1) (Not b)) = Sub (Lit 0) b | ||
| go (Xor (Lit a) b) | a == maxLit = Not b |
Collaborator
There was a problem hiding this comment.
Let's move the Xor rule to the Xor section below.
Also, not sure what will happen if b is a literal. I guess the result should actually be Expr.not b? WDYT?
Collaborator
Author
There was a problem hiding this comment.
I'm moving it lower down. It'll make it into Not b which SHOULD call EVM.Expr.not to simplify concrete values but that's missing! WOW. Oooooops. We literally never simplify negated concrete values :S Adding that into this PR.
Co-authored-by: blishko <blishko@argot.org>
Co-authored-by: blishko <blishko@argot.org>
msooseth
force-pushed
the
more-expr-simp
branch
from
47e30f5 to
31d4ef9
Compare
msooseth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two new rewrites:
Checklist